Fix a false positive for no-value-for-parameter#9038
Merged
Pierre-Sassoulas merged 1 commit intoSep 14, 2023
Conversation
…od is called in a class body. Closes pylint-dev#9036
mbyrnepr2
added
the
False Positive 🦟
mbyrnepr2
commented
Sep 13, 2023
| # includes an implicit `self` argument which is not present in `called.args`. | ||
| if ( | ||
| isinstance(node.frame(), nodes.ClassDef) | ||
| and isinstance(node.parent, (nodes.Assign, nodes.AnnAssign)) |
Member
Author
There was a problem hiding this comment.
This if block was added by me originally. I don't think there was any need to specify that this node was an assignment; i.e. this should be checked also:
class X:
def func(xx):
...
func("test")
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9038 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 173 173
Lines 18648 18648
=======================================
Hits 17856 17856
Misses 792 792
|
Contributor
Pierre-Sassoulas
approved these changes
Sep 14, 2023
Member
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
The primers look convincing :D
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.17.x maintenance/2.17.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.17.x
# Create a new branch
git switch --create backport-9038-to-maintenance/2.17.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 48781fe2c8bbc6f88455c44b5894bb75c873385a
# Push it to GitHub
git push --set-upstream origin backport-9038-to-maintenance/2.17.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.17.xThen, create a pull request where the |
Pierre-Sassoulas
added
the
Needs backport
Pierre-Sassoulas
added
Backported
and removed
Needs backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix a false positive for
no-value-for-parameterwhen a staticmethod is called in a class body.Closes #9036